Hive Hive
Sign in

fix(web): restore scrolling after delete modal navigation

GitHub issue · Closed

Metadata
Source
tuist/hive #72
Updated
Jun 24, 2026
Domains
Hive
Details

What changed

This closes the delete modal before navigating away after a successful project or domain deletion.

Why

After deleting a project from its modal, the projects page can return with the success badge visible while page scrolling remains locked.

Root cause

The Noora modal locks page scrolling while open. The delete handlers navigated away after setting flash state without sending the close event, so the lock could remain on the body after the LiveView navigation.

Approach

Send the existing close-modal event for the delete modal before push_navigate. This keeps the fix scoped to the modal-backed delete flows and lets the existing modal cleanup clear the scroll lock.

Impact

Visitors can scroll the projects and domains lists normally after deleting an item. No data model or route behavior changes.

Validation

  • mise exec -- mix test test/hive_web/live/project_live/show_test.exs test/hive_web/live/domain_live/show_test.exs
  • Reproduced and verified locally with headless Chrome: deleting a project from the modal no longer leaves page scrolling locked after returning to /projects.
Comments

No GitHub comments yet.