kura: remove the single-port cutover transition shims

PR #11591 collapsed Kura to a single co-hosted HTTP + gRPC listener. Two deliberately temporary compatibility shims shipped with it and should be removed once the fleet is fully past the cutover:

1. Transitional KURA_GRPC_PORT env in the kura-controller

infra/kura-controller/controllers/kurainstance_controller.go (baseEnv) still sets KURA_GRPC_PORT=50051 because pre-cohosted images hard-require it and would crash-loop — taking the HTTP cache down — when the controller rewrites their pod template. Co-hosted images ignore it.

Remove when: every KuraInstance in every environment reports an observedImage at a co-hosted release (any kura@ release after 0.10.15, or a post-cutover sha-… build). Also remove: the accompanying TestBaseEnvKeepsTransitionalGRPCPortForPreCohostedImages test and the transition paragraph in infra/kura-controller/AGENTS.md.

2. nodePortHTTP fallback read in the server provisioner

server/lib/tuist/kura/provisioner/kubernetes_controller.ex (external_endpoint/2) reads status.nodePortCache with a fallback to the pre-rename status.nodePortHTTP, so an older controller can still feed dispatch during the rollout.

Remove when: every environment runs a kura-controller that publishes nodePortCache (any controller built from this PR onward) and live CR statuses have been rewritten by at least one reconcile. Also remove: the “falls back to the pre-rename nodePortHTTP field” test in server/test/tuist/kura/provisioner/kubernetes_controller_test.exs.

Both shims are one-line removals plus their tests/docs; neither affects behavior on an up-to-date fleet.

🤖 Generated with Claude Code

No GitHub comments yet.