Hive
fix(server): handle in-progress VCS test comments
GitHub issue · Closed
What changed
- Added PR comment rendering coverage for an Xcode test run whose status is
in_progress. - Updated the VCS test-run status formatter to render non-terminal test states instead of raising:
in_progressandprocessingrender as pending.failed_processingrenders as a warning.- unexpected statuses render as unknown.
Why it changed
Sentry issue TUIST-ZP showed Tuist.VCS.Workers.CommentWorker failing in production while building the Tuist run report for a PR. The worker received a valid test-run status, in_progress, from the sharded test-run flow, but Tuist.VCS.get_test_run_status_text/1 only handled terminal statuses.
Root cause
Tuist.Tests.Test already accepts in_progress, processing, and failed_processing as valid statuses. VCS comment formatting had a narrower case expression with only failure, success, and skipped, so any in-progress sharded run crashed comment generation with a CaseClauseError.
Impact
PR comments can now include in-progress or processing test runs without retrying and failing the vcs_comments Oban job. Unknown future statuses degrade to a visible placeholder instead of taking down comment rendering.
Validation
- Reproduced the failure with
mix test test/tuist/vcs_test.exs:1462before the fix. - Ran
mix format lib/tuist/vcs.ex test/tuist/vcs_test.exs. - Ran
mix test test/tuist/vcs_test.exs-> 104 tests, 0 failures.
Fixes TUIST-ZP
No GitHub comments yet.